-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove request json parsing from the worker file #201
Conversation
remove request body JSON parsing from worker file
Thank you for your work, @mouhannad-sh! Looks great. Yes, let's add at least one basic test that asserts an explicit empty string body (
Take a look at how test actions/assertions are written for more details, I'm sure it'd be straightforward. Let me know if you have any questions. |
I've rebased your branch and will provide the tests, if you don't mind. |
Hey, I've took this pull request as an opportunity to structure the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these changes, you make the library much better! You rock.
Thanks a lot @kettanaito you're a life saver 🔥 |
Hey guys, I like this library, can you please release the current Master as we are stuck at #200 . Thanks so much! |
@sumitj18s thanks for the feedback. The fix is released in |
Thanks @kettanaito a lot for such prompt release & response! |
Fixes #200
Do we need to add any tests to cover the case of empty body responses ? if so, can you guide me to where I need to start ?
Thanks